-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated diff to show \t in string comparison assertions #10961
Open
mthaitan
wants to merge
11
commits into
pytest-dev:main
Choose a base branch
from
HSamiul:whitespace/dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8c622d2
Added test to check error diffs with different spacing
egwetzel 1e5fa13
Added testing to for our new functionality (functionality not impleme…
egwetzel 75e3cc4
added tab printing in diff messages
mthaitan e2e9f7d
passing new test, need to fix other tests
mthaitan f55cec3
finished issue, added changelog and names to authors file
mthaitan 0b8c3de
fixed changelog statement
mthaitan 042bc2d
fixed tab to show repr
mthaitan a8c868d
Merge branch 'main' into whitespace/dev
egwetzel a8a8e49
Merge branch 'main' into whitespace/dev
egwetzel 7e05578
fixed test id
mthaitan f083d5c
Merge branch 'whitespace/dev' of github.com:HSamiul/cakepop-pytest in…
mthaitan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Changed the diff explanation for string comparison assertions when there is a tab in the string to show ``\t`` instead of four spaces. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong to me - there are no tab characters in the original strings, so we're actually lying about the contents by replacing four spaces!
I think we need a different approach, perhaps showing the
repr
of the explanation lines in question if they differ in their trailing whitespace; or maybe only showing that for the trailing whitespace in question. Check out what the short summary does I guess?