Handle microseconds with custom logging.Formatter #11047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
May 30, 2023
There was a problem hiding this comment.
Looks great, thnaks a lot @theirix!
Left two minor comments, other than that LGTM. 👍
Removed default constructor and documentation for the internal class. Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
for more information, see https://pre-commit.ci
|
Glad to help, @nicoddemus ! |
|
Thx for the fix, but shouldn't the fix be implemented upstream in the stdlib? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of
%fdirective to print microseconds in log format options, such aslog-date-format. It is impossible to do with a standardlogging.Formatterbecause it usestime.strftimewhich doesn't know about milliseconds and%f. In this PR I added a custom Formatter which convertsLogRecordto adatetime.datetimeobject and formats it with%fflag. This behaviour is enabled only if a microsecond flag is specified in a format string.Also added a few tests to check the standard and changed behaviour.
Closes #10991.