Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the fixture for spam function #12209

Closed

Conversation

erjan
Copy link

@erjan erjan commented Apr 12, 2024

head-fork: erjan/pytest
compare: improving-small-test-foo-function

base-fork: pytest-dev/pytest
base: main

improved the return with print statement

@erjan
Copy link
Author

erjan commented Apr 13, 2024

adding some improvement

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but can you elaborate why is this an improvement?

@erjan
Copy link
Author

erjan commented Apr 14, 2024

Thanks, but can you elaborate why is this an improvement?

the function needs to print out info before returning.

@The-Compiler
Copy link
Member

There's no reason this needs to print anything (even more so given that the print wouldn't even be shown anywhere).

@erjan erjan deleted the improving-small-test-foo-function branch April 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants