Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Fix consider-using-sys-exit, use-yield-from, and implicit-str-concat #12379

Merged
merged 4 commits into from
May 29, 2024

Conversation

Pierre-Sassoulas
Copy link
Contributor

Follow-up to #12172

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the pointless-x-statement changes don't really improve things, I'd leave it out (but I don't feel strongly about this).

I think there is some confusion in the commit subject [pylint 'implicit-str-concat'] Use zip when iterating on two iterators.

Other than that LGTM, thanks!

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the more-pylint-fixes branch 2 times, most recently from 9aff37f to 741f92a Compare May 29, 2024 11:31
@Pierre-Sassoulas
Copy link
Contributor Author

IMO, the pointless-x-statement changes don't really improve things, I'd leave it out (but I don't feel strongly about this).

Removed (the benefit would be to be able to see new violations without having low values warning, I agree that the diff is not much better). Either ruff did not catch them or they filtered this when in a pytest.raises / unitest.assertRaises, which make sense.

I think there is some confusion in the commit subject [pylint 'implicit-str-concat'] Use zip when iterating on two iterators.

Yeah, nice catch, probably reused an old message without updating properly, fixed.

@Pierre-Sassoulas Pierre-Sassoulas changed the title [pylint] Fix consider-using-sys-exit, use-yield-from, implicit-str-concat and pointless-x-statement [pylint] Fix consider-using-sys-exit, use-yield-from, and implicit-str-concat May 29, 2024
@Pierre-Sassoulas Pierre-Sassoulas merged commit 0ba3e91 into pytest-dev:main May 29, 2024
27 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the more-pylint-fixes branch May 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants