Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Make a draft based plugin bump PR CI trigger #12502

Conversation

webknjaz
Copy link
Member

Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:

webknjaz added a commit to webknjaz/pytest that referenced this pull request Jun 20, 2024
@webknjaz webknjaz force-pushed the maintenance/ci-plugin-update-draft-ux branch from 83bf818 to d03b7f9 Compare June 20, 2024 18:22
Normally, PRs/commits published using the default GitHub Actions CI/CD
API token are not propagated to any integrations. This patch marks the
plugin update PR as a draft and leaves a comment asking the maintainers to
mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:
* github/codeql-action#2263 (comment)
* https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41
* github/codeql-action#1868
* github/codeql-action#679
@webknjaz webknjaz force-pushed the maintenance/ci-plugin-update-draft-ux branch from d03b7f9 to 072cb52 Compare June 21, 2024 12:11
@webknjaz webknjaz marked this pull request as ready for review June 21, 2024 12:11
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 21, 2024
@webknjaz
Copy link
Member Author

@RonnyPfannschmidt this is ready to be auto-merged ^

@RonnyPfannschmidt RonnyPfannschmidt merged commit c8948fc into pytest-dev:main Jun 21, 2024
28 of 31 checks passed
- opened # default
- synchronize # default
- reopened # default
- ready_for_review # used in PRs created from the release workflow
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future: the code comment refers to the release workflow, but it's actually update-plugin-list.yml. We need to update the comment at some point.

@webknjaz webknjaz added the type: infrastructure improvement to development/releases/CI structure label Jun 26, 2024
webknjaz added a commit to webknjaz/pytest that referenced this pull request Jul 2, 2024
CI runs. From now on, they only need to click the `Ready for review`
button instead.

-- by :user:`webknjaz`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing period correction: #12561.

webknjaz added a commit that referenced this pull request Jul 2, 2024
…02--ci-plugin-update-draft-ux

📝💄 Drop trailing period from #12502 byline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided (automation) changelog entry is part of PR type: infrastructure improvement to development/releases/CI structure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants