New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 1496 - xfail with condition keyword #1524

Merged
merged 1 commit into from May 31, 2016

Conversation

Projects
None yet
3 participants
@tomviner
Contributor

tomviner commented Apr 19, 2016

Fix for #1496 Xfail does not work with condition keyword argument.

We were only looking at args, despite the docs saying:

Here’s the signature of the xfail marker, using Python 3 keyword-only arguments syntax:
def xfail(condition=None, *, reason=None, raises=None, run=True, strict=False):

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Apr 19, 2016

Cool, many thanks! 😎

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Apr 19, 2016

@RonnyPfannschmidt could you please take a look and merge if you are also OK with it?

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Apr 19, 2016

at first glance its ok will take a deeper look in a bit

@tomviner

This comment has been minimized.

Contributor

tomviner commented Apr 19, 2016

@RonnyPfannschmidt I just simplified a little. I've rebased this branch, but I've pushed the edit here: tomviner@4b5640a

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented May 23, 2016

@RonnyPfannschmidt did you get a chance to take a better look on this? 😁

@RonnyPfannschmidt RonnyPfannschmidt merged commit 99c4b6f into pytest-dev:master May 31, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tomviner tomviner deleted the tomviner:issue-1496-xfail-cond-kw branch May 31, 2016

@pyup-bot pyup-bot referenced this pull request Sep 12, 2016

Merged

Initial Update #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment