New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark empty doctest files as skipped, fixes #1578 #1580

Merged
merged 1 commit into from Jun 1, 2016

Conversation

Projects
None yet
5 participants
@graingert
Contributor

graingert commented Jun 1, 2016

No description provided.

@The-Compiler

This comment has been minimized.

Member

The-Compiler commented Jun 1, 2016

I don't really understand the implications of the change, but it seems like it made a lot of tests fail 😉

@graingert

This comment has been minimized.

Contributor

graingert commented Jun 1, 2016

@The-Compiler yeah I know :p

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Jun 1, 2016

i think this is related to fixture support for docktests, @nicoddemus do you remember details by chance?

items, reprec = testdir.inline_genitems(w)
assert len(items) == 1

This comment has been minimized.

@graingert

graingert Jun 1, 2016

Contributor

this looks like it was a test bug

This comment has been minimized.

@nicoddemus
@graingert

This comment has been minimized.

Contributor

graingert commented Jun 1, 2016

requires #1582 to pass

@coveralls

This comment has been minimized.

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.002%) to 92.204% when pulling cd427a1 on graingert:fix-all-skipped-but-none-exist into 7305adf on pytest-dev:master.

@coveralls

This comment has been minimized.

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.002%) to 92.204% when pulling 3aa6858 on graingert:fix-all-skipped-but-none-exist into 7305adf on pytest-dev:master.

@coveralls

This comment has been minimized.

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.002%) to 92.204% when pulling 3aa6858 on graingert:fix-all-skipped-but-none-exist into 7305adf on pytest-dev:master.

@coveralls

This comment has been minimized.

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.002%) to 92.204% when pulling 74862b8 on graingert:fix-all-skipped-but-none-exist into 057007f on pytest-dev:master.

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jun 1, 2016

Looks good, it makes much more sense for DoctestTextfile to collect items instead of being an item itself. 😁

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jun 1, 2016

Only missing CHANGELOG and AUTHORS, but I will update those myself before merging (right after AppVeyor passes).

@graingert

This comment has been minimized.

Contributor

graingert commented Jun 1, 2016

AppVeyor is slooooooww

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jun 1, 2016

Yep, it doesn't have multiple jobs like Travis, so we wait. 😌

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Jun 1, 2016

@nicoddemus nicoddemus merged commit 74862b8 into pytest-dev:master Jun 1, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jun 1, 2016

Merged, thanks again @graingert!

(The AppVeyor failure was unrelated, will see to that in a separate PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment