Exit pytest on collection error (without executing tests) #1628

omarkohl · 2016-06-21T10:29:46Z

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

Target: for bug or doc fixes, target master; for new features, target features
Make sure to include one or more tests for your change
Add yourself to AUTHORS
Add a new entry to the CHANGELOG (choose any open position to avoid merge conflicts with other PRs)

The-Compiler · 2016-06-21T10:52:46Z

LGTM, great work! Let's see how the tests turn out...

coveralls · 2016-06-21T10:53:50Z

Coverage increased (+0.02%) to 92.406% when pulling 778c0cf on omarkohl:exit_on_collection_error into 54872e9 on pytest-dev:features.

coveralls · 2016-06-21T11:02:06Z

Coverage increased (+0.02%) to 92.406% when pulling 778c0cf on omarkohl:exit_on_collection_error into 54872e9 on pytest-dev:features.

Add --continue-on-collection-errors option to restore the previous behaviour: Execute tests (that were successfully collected) even when collection errors happen. Some tests had to be modified e.g. because the return code changed to 2 (EXIT_INTERRUPTED) instead of 1 (EXIT_TESTSFAILED) because an Interrupted exception is raised on collection error. Implemented via pair programming with: Oleg Pidsadnyi <oleg.pidsadnyi@gmail.com> closes #1421

coveralls · 2016-06-21T11:37:59Z

Coverage increased (+0.02%) to 92.406% when pulling ede7478 on omarkohl:exit_on_collection_error into 54872e9 on pytest-dev:features.

nicoddemus · 2016-06-21T15:55:55Z

testing/test_collection.py

@@ -642,3 +642,114 @@ def test___repr__():
        """)
        reprec = testdir.inline_run("-k repr")
        reprec.assertoutcome(passed=1, failed=0)
+
+
+COLLECTION_ERROR_PY_FILES = dict(


Just a tip: sometimes these type of metadata is better put into a session fixture. 😉

nicoddemus · 2016-06-21T16:03:18Z

Tested it on my windows laptop since AppVeyor is stuck (py27,py35,linting).

nicoddemus reviewed Jun 21, 2016
View changes

nicoddemus merged commit 2305d32 into pytest-dev:features Jun 21, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

The-Compiler mentioned this pull request Jul 7, 2016

Exit pytest if a collection error occours #1421

Closed

This was referenced Aug 31, 2016

Update pytest to 3.0.1 jkahn/islex-entities#13

Merged

Initial Update pghalliday/test_cookiecutter#1

Open

Initial Update pghalliday/zdm#1

Open

pyup-bot mentioned this pull request Nov 22, 2017

Pin pytest to latest version 3.2.5 Opentrons/opentrons#443

Closed

blueyed mentioned this pull request Nov 25, 2017

Distinct exit code for collection errors #2950

Closed

pytest-dev / pytest

Exit pytest on collection error (without executing tests) #1628

Exit pytest on collection error (without executing tests) #1628

omarkohl commented Jun 21, 2016

The-Compiler commented Jun 21, 2016

coveralls commented Jun 21, 2016 •

edited

coveralls commented Jun 21, 2016 •

edited

coveralls commented Jun 21, 2016 •

edited

This comment has been minimized.

nicoddemus commented Jun 21, 2016

pytest-dev / pytest

Sponsor pytest-dev/pytest

Exit pytest on collection error (without executing tests) #1628

Exit pytest on collection error (without executing tests) #1628

Conversation

omarkohl commented Jun 21, 2016

The-Compiler commented Jun 21, 2016

coveralls commented Jun 21, 2016 • edited

coveralls commented Jun 21, 2016 • edited

coveralls commented Jun 21, 2016 • edited

This comment has been minimized.

nicoddemus Jun 21, 2016 Member

nicoddemus commented Jun 21, 2016

coveralls commented Jun 21, 2016 •

edited

coveralls commented Jun 21, 2016 •

edited

coveralls commented Jun 21, 2016 •

edited

nicoddemus Jun 21, 2016
Member