Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Argument.__repr__ #1648

Merged
merged 1 commit into from Jun 25, 2016

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 22, 2016

I have came across this when noticing that universal-ctags fails to parse
this correctly (universal-ctags/ctags#997).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 92.237% when pulling b3c4ecc on blueyed:simplify-Argument-repr into 6359e75 on pytest-dev:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 22, 2016

Coverage Status

Coverage decreased (-0.003%) to 92.237% when pulling b3c4ecc on blueyed:simplify-Argument-repr into 6359e75 on pytest-dev:master.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 22, 2016

Rong - will add a test.

@blueyed blueyed self-assigned this Jun 22, 2016
@nicoddemus
Copy link
Member

Rong - will add a test.

You plan to write a test for this first @blueyed?

@blueyed blueyed force-pushed the simplify-Argument-__repr__ branch from b3c4ecc to 0f61b59 Compare June 24, 2016 14:47
@blueyed
Copy link
Contributor Author

blueyed commented Jun 24, 2016

@nicoddemus
Yep, done. Let's see if now still passes.

@blueyed blueyed removed their assignment Jun 24, 2016
@nicoddemus
Copy link
Member

Failed apparently, could you take a look please?

I have came across this when noticing that universal-ctags fails to parse
this correctly (universal-ctags/ctags#997).
@blueyed blueyed force-pushed the simplify-Argument-__repr__ branch from 0f61b59 to 939407e Compare June 25, 2016 07:31
@coveralls
Copy link

coveralls commented Jun 25, 2016

Coverage Status

Coverage increased (+0.02%) to 92.254% when pulling 939407e on blueyed:simplify-Argument-repr into 0c63762 on pytest-dev:master.

@nicoddemus nicoddemus merged commit df17f86 into pytest-dev:master Jun 25, 2016
@nicoddemus
Copy link
Member

Thanks! 😁

@blueyed blueyed deleted the simplify-Argument-__repr__ branch June 26, 2016 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants