Pass exitstatus to pytest_terminal_summary hook

[blueyed]

This is useful to know if a testrun has been interrupted
(EXIT_INTERRUPTED).

• Add a new entry to CHANGELOG.rst

[blueyed]

I came up with it for ratson/pytest-notifier#3.

But then I wonder if it could be just stored on the module level from the pytest_sessionfinish hook - instead of wrapping the plugin into a class instance?

[blueyed]

@coveralls is acting up: https://travis-ci.org/pytest-dev/pytest/jobs/152252335

[coveralls]

Coverage remained the same at 93.103% when pulling 5b95ee3 on blueyed:exitstatus-with-pytest_terminal_summary into 99a4a1a on pytest-dev:features.

[nicoddemus]

Thanks @blueyed! 👍

[blueyed]

@nicoddemus
Any feedback on my questions? (especially if it's really necessary)
And the open TODO item about the changelog entry? (Shouldn't it be added there?)

[nicoddemus]

Any feedback on my questions? (especially if it's really necessary)

Sorry I missed them!

But then I wonder if it could be just stored on the module level from the pytest_sessionfinish hook - instead of wrapping the plugin into a class instance?

Not sure what do you mean here, care to elaborate?

And the open TODO item about the changelog entry? (Shouldn't it be added there?)

I did it myself in 4971525. 😁

[blueyed]

What I did in ratson/pytest-notifier#3 works already.
(And it might not be necessary to wrap it into a plugin instance)

So just getting the exitstatus in the pytest_sessionfinish hook, storing it on the module and then using it from there in the pytest_terminal_summary should work and might be even the way to go?!

[blueyed]

Anyway, I still think it's fine to have it a bit easier and since it's merged already: 🎆

[nicoddemus]

Anyway, I still think it's fine to have it a bit easier and since it's merged already

I agree! 😁