Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcase reports with a url attribute will now properly write this to… #1874

Merged
merged 1 commit into from Sep 19, 2016
Merged

Testcase reports with a url attribute will now properly write this to… #1874

merged 1 commit into from Sep 19, 2016

Conversation

@fushi
Copy link

@fushi fushi commented Aug 25, 2016

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • [*] Target: for bug or doc fixes, target master; for new features, target features;
  • [*] Make sure to include one or more tests for your change;
  • [*] Add yourself to AUTHORS;
  • [*] Add a new entry to CHANGELOG.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using RST syntax.
    • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

… junitxml

@coveralls
Copy link

@coveralls coveralls commented Aug 25, 2016

Coverage Status

Coverage increased (+0.002%) to 93.028% when pulling 1b259f7 on fushi:url_attr into 9c45d6c on pytest-dev:master.

@fushi fushi closed this Aug 25, 2016
@fushi fushi reopened this Aug 25, 2016
@fushi
Copy link
Author

@fushi fushi commented Aug 25, 2016

Just triggering a rerun of travis with the close/open routine

@coveralls
Copy link

@coveralls coveralls commented Aug 25, 2016

Coverage Status

Coverage increased (+0.002%) to 93.028% when pulling 1b259f7 on fushi:url_attr into 9c45d6c on pytest-dev:master.

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 26, 2016

Thanks! According to the junit-plugin schema this is valid on Jenkins, but could you explain your use case better? Do you have custom hooks that add that attribute to test reports?

@fushi
Copy link
Author

@fushi fushi commented Aug 26, 2016

I do! We're using this to point to where our test artifacts are, so that when you see a failure in phabricator, you can be linked directly to the artifacts in jenkins

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 26, 2016

@fushi I see, thanks. This seems like a new feature (albeit small), so perhaps this should go into the features branch and be released on 3.1.0? Let's see what others have to say.

Also I wonder how to better document that.

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Aug 26, 2016

I agree this should go to features.

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Aug 26, 2016

@fushi could you change the target of this PR to features then?

@flub flub changed the base branch from master to features Sep 19, 2016
@flub flub merged commit 1b259f7 into pytest-dev:features Sep 19, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flub
Copy link
Member

@flub flub commented Sep 19, 2016

Apparently we can change the target ourselves using the edit button at the top of the page :-)

This was referenced Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants