Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify test discovery docs. #2090

Merged
merged 1 commit into from Nov 26, 2016
Merged

Conversation

avojnovicDk
Copy link
Contributor

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features;

Unless your change is trivial documentation fix (e.g., a typo or reword of a small section) please:

  • Make sure to include one or more tests for your change;
  • Add yourself to AUTHORS;
  • Add a new entry to CHANGELOG.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using RST syntax.
    • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.819% when pulling 2e6a58a on avojnovicDk:issue-1808 into 33796c8 on pytest-dev:master.

@nicoddemus
Copy link
Member

Thanks! Your version does read better!

I'm re-triggering AppVeyor because the failed job seems to be a fluke. As soon as it passes I'll merge this.

@nicoddemus
Copy link
Member

Actually it does not seem to be a fluke, I will investigate it.

@nicoddemus
Copy link
Member

Not a fluke, but unrelated to this PR: pypa/setuptools#861

@nicoddemus
Copy link
Member

I tested locally your PR merged with #2092 and it passes, so I'm merging this.

Thanks again!

@nicoddemus nicoddemus merged commit a6084ed into pytest-dev:master Nov 26, 2016
@decentral1se
Copy link
Contributor

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants