Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python api code to own file #2489

Merged
merged 3 commits into from Jun 11, 2017

Conversation

Projects
None yet
3 participants
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Jun 11, 2017

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

RonnyPfannschmidt added some commits Jun 11, 2017

move python api helpers out of the python module
this separates exposed normal api from collection elements
@nicoddemus
Copy link
Member

nicoddemus left a comment

Perhaps we should call the new file just api.py?

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Jun 11, 2017

Also what's the intent for moving those classes?

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member Author

RonnyPfannschmidt commented Jun 11, 2017

@nicoddemus cutting down the file sizes before introducing FunctionDefinition?

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:move-python-api branch from cce9c99 to f8b2277 Jun 11, 2017

@RonnyPfannschmidt RonnyPfannschmidt changed the title [WIP] Move python api code to own file Move python api code to own file Jun 11, 2017

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Jun 11, 2017

OK, was just wondering. python_api sounds like something we want to make public, that's why I asked.

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member Author

RonnyPfannschmidt commented Jun 11, 2017

wrt the filename - api.py seems a bit short and non-saying - same for python api

i do wonder about splitting logical bits into more files

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage increased (+0.004%) to 92.132% when pulling cce9c99 on RonnyPfannschmidt:move-python-api into 467c526 on pytest-dev:features.

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member Author

RonnyPfannschmidt commented Jun 11, 2017

but yeah, this can be merged ^^

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage increased (+0.004%) to 92.132% when pulling f8b2277 on RonnyPfannschmidt:move-python-api into 467c526 on pytest-dev:features.

@nicoddemus nicoddemus merged commit 9bd8907 into pytest-dev:features Jun 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:move-python-api branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.