Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clarify when hooks stop after the first non-None result #2497

Merged
merged 2 commits into from
Jun 13, 2017

Conversation

pkch
Copy link
Contributor

@pkch pkch commented Jun 13, 2017

Fixes #2493

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.128% when pulling 4a992ba on pkch:firstresult into f0541b6 on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 6fa7b16 into pytest-dev:master Jun 13, 2017
@RonnyPfannschmidt
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: API for pytest_collect_file
3 participants