Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb: resume capturing after continue #2619

Merged
merged 2 commits into from Oct 25, 2018

Commits on Oct 25, 2018

  1. pdb: resume capturing after continue

    After `pdb.set_trace()` capturing is turned off.
    This patch resumes it after using the `continue` (or `c` / `cont`)
    command.
    
    Store _pytest_capman on the class, for pdbpp's do_debug hack to keep it.
    
    Without this, `debug …` would fail like this:
    
        /usr/lib/python3.6/cmd.py:217: in onecmd
            return func(arg)
        .venv/lib/python3.6/site-packages/pdb.py:608: in do_debug
            return orig_do_debug(self, arg)
        /usr/lib/python3.6/pdb.py:1099: in do_debug
            sys.call_tracing(p.run, (arg, globals, locals))
        /usr/lib/python3.6/bdb.py:434: in run
            exec(cmd, globals, locals)
        /usr/lib/python3.6/bdb.py:51: in trace_dispatch
            return self.dispatch_line(frame)
        /usr/lib/python3.6/bdb.py:69: in dispatch_line
            self.user_line(frame)
        /usr/lib/python3.6/pdb.py:261: in user_line
            self.interaction(frame, None)
        .venv/lib/python3.6/site-packages/pdb.py:203: in interaction
            self.setup(frame, traceback)
        E   AttributeError: 'PytestPdb' object has no attribute '_pytest_capman'
    
    - add pytest_leave_pdb hook
    - fixes test_pdb_interaction_capturing_twice: would fail on master now,
      but works here
    blueyed committed Oct 25, 2018
    Copy the full SHA
    a4ea66c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ede3a4e View commit details
    Browse the repository at this point in the history