Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record_property is no longer experimental #3360

Merged
merged 3 commits into from
Apr 5, 2018
Merged

record_property is no longer experimental #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211f3c4
record_property is no longer experimental
RonnyPfannschmidt Apr 1, 2018
7c0c91a
fix record_property test
RonnyPfannschmidt Apr 3, 2018
2018cf1
fix the record_property test
RonnyPfannschmidt Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions _pytest/junitxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,6 @@ def record_property(request):
def test_function(record_property):
record_property("example_key", 1)
"""
request.node.warn(
code='C3',
message='record_property is an experimental feature',
)

def append_property(name, value):
request.node.user_properties.append((name, value))
return append_property
Expand Down
2 changes: 2 additions & 0 deletions changelog/3360.trivial
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
record_property is no longer experimental, removing the warnings was forgotten.

6 changes: 1 addition & 5 deletions testing/test_junitxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,17 +868,13 @@ def other(record_property):
def test_record(record_property, other):
record_property("foo", "<1");
""")
result, dom = runandparse(testdir, '-rw')
result, dom = runandparse(testdir, '-rwv')
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
psnode = tnode.find_first_by_tag('properties')
pnodes = psnode.find_by_tag('property')
pnodes[0].assert_attr(name="bar", value="1")
pnodes[1].assert_attr(name="foo", value="<1")
result.stdout.fnmatch_lines([
'test_record_property.py::test_record',
'*record_property*experimental*',
])


def test_record_property_same_name(testdir):
Expand Down