Attempt to solve race-condition which corrupts .pyc files on Windows #3390
+23
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
atomic-pyc-writes
branch
from
749c634
to
9727e01
Compare
nicoddemus
force-pushed
the
atomic-pyc-writes
branch
from
9727e01
to
4dca5a4
Compare
| size = source_stat.size & 0xFFFFFFFF | ||
| fp.write(struct.pack("<ll", mtime, size)) | ||
| if six.PY2: | ||
| marshal.dump(co, fp.file) |
There was a problem hiding this comment.
that bit looks strange why is that kind of access needed?
There was a problem hiding this comment.
It fails on PY2 because fp is not a real file object, it is a _TemporaryFile (or something like that). In PY3 just passing fp to marshal.dump works.
It is probably possible to use marshal.dump(co, fp.file) in both Python 2 and 3, but I prefer to separate those cases so when the time comes around to drop Python 2 it is clear that we can keep the "cleaner" version.
RonnyPfannschmidt
approved these changes
Apr 12, 2018
|
@nicoddemus please rebase, then i'll merge ^^ |
This uses of the `atomicwrites` library. This is very hard to create a reliable test for. Fix pytest-dev#3008
nicoddemus
force-pushed
the
atomic-pyc-writes
branch
from
4dca5a4
to
aa95a42
Compare
|
Rebased, thanks @RonnyPfannschmidt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses of the
atomicwriteslibrary.This is very hard to create a reliable test for.
Fix #3008