Improve performance of ~3 of the slowest tests #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't recall why, and looking at the test itself no clear reason jumps to me... if things are passing, I say let's keep your changes. 😁 |
nicoddemus
reviewed
Oct 8, 2018
testing/code/test_excinfo.py
Outdated
| @@ -1361,40 +1371,30 @@ def a(x): | |||
| def b(x): | |||
| return a(numpy_like()) | |||
|
|
|||
| try: | |||
| with pytest.raises(RecursionError) as excinfo: | |||
There was a problem hiding this comment.
RecursionError is py35+ (or py36+) only; IIRC you need to use RuntimeError instead.
There was a problem hiding this comment.
dang, I always forget this 😭
Codecov Report
@@ Coverage Diff @@
## master #4090 +/- ##
=========================================
- Coverage 94.47% 94.4% -0.08%
=========================================
Files 109 109
Lines 23813 23811 -2
Branches 2349 2349
=========================================
- Hits 22498 22478 -20
- Misses 1007 1021 +14
- Partials 308 312 +4
Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Oct 8, 2018
|
Noice! 👍 |
RonnyPfannschmidt
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked a few from
pytest testing/{subdir} --durations=5and wanted to see what I could do to make them faster.this saves ~11 seconds off of a test run (which isn't much but it's something!)
interesting to note that
runpytest_subprocessadds about 500ms per invocation. (I guess we should avoid it if possible? @nicoddemus do you know if there's a reason why it was used for #3124?)