Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] tests: harden test_cmdline_python_package_symlink #4106

Closed
wants to merge 2 commits into from
Closed

[WIP] tests: harden test_cmdline_python_package_symlink #4106

wants to merge 2 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 10, 2018 •
edited

This tests that symlinks are not resolved there currently.

Relevant for when I've worked on #4108.

@coveralls
Copy link

coveralls commented Oct 10, 2018 •
edited

Coverage Status

Coverage increased (+0.02%) to 93.805% when pulling 2f058ad on blueyed:harden into 943bbdd on pytest-dev:features.

@blueyed blueyed changed the title tests: harden test_cmdline_python_package_symlink [WIP] tests: harden test_cmdline_python_package_symlink Oct 11, 2018
@nicoddemus
Copy link
Member

What's missing here @blueyed?

@blueyed blueyed mentioned this pull request Oct 12, 2018
Merged
@blueyed
Copy link
Contributor Author

blueyed commented Oct 12, 2018

@nicoddemus
I've taken out the first commit into #4123.
This is then meant to become the base for #4108.

@blueyed blueyed closed this Oct 12, 2018
@blueyed blueyed deleted the harden branch October 12, 2018 13:19
@pytest-dev pytest-dev deleted a comment from codecov bot Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blueyed @coveralls @nicoddemus