Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken error message in pytester #4898

Merged
merged 3 commits into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@shoyer
Copy link
Contributor

shoyer commented Mar 8, 2019

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #4898 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4898      +/-   ##
==========================================
- Coverage   95.67%   95.64%   -0.03%     
==========================================
  Files         113      113              
  Lines       25169    25169              
  Branches     2498     2498              
==========================================
- Hits        24080    24074       -6     
- Misses        767      775       +8     
+ Partials      322      320       -2
Impacted Files Coverage Δ
src/_pytest/pytester.py 87.05% <ø> (ø) ⬆️
src/_pytest/doctest.py 94.2% <0%> (-2.18%) ⬇️
src/_pytest/unittest.py 93.12% <0%> (-1.06%) ⬇️
testing/acceptance_test.py 97.43% <0%> (-0.43%) ⬇️
testing/test_pdb.py 98.84% <0%> (-0.24%) ⬇️
src/_pytest/terminal.py 91.74% <0%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ef546...a0f652c. Read the comment docs.

@nicoddemus
Copy link
Member

nicoddemus left a comment

Thanks! Could you please include a trivial changelog as well?

@shoyer

This comment has been minimized.

Copy link
Contributor Author

shoyer commented Mar 9, 2019

Sorry, I don't have time to figure out the full developer setup for pytest

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Mar 9, 2019

No worries, I just did it. Thanks again!

@nicoddemus nicoddemus merged commit 0f3d630 into pytest-dev:master Mar 9, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
pytest-CI in progress
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.