Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into features #5058

Merged
merged 4 commits into from
Apr 5, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 5, 2019

No description provided.

@@ -0,0 +1 @@
Fix regression with ``--pdbcls``, which stopped working with local modules in 4.0.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, you think this regression deserves a quick fix release @blueyed? If so please feel free to prepare one (from master of course). 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think it is urgent - after all it might help to discover the new feature behind it.. ;)

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #5058 into features will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5058      +/-   ##
============================================
+ Coverage     95.69%   96.07%   +0.38%     
============================================
  Files           114      114              
  Lines         25812    25823      +11     
  Branches       2554     2554              
============================================
+ Hits          24701    24810     +109     
+ Misses          803      704      -99     
- Partials        308      309       +1
Impacted Files Coverage Δ
src/_pytest/debugging.py 88.88% <100%> (+0.3%) ⬆️
testing/test_pdb.py 99.2% <100%> (ø) ⬆️
src/_pytest/terminal.py 92.45% <0%> (+0.49%) ⬆️
testing/test_assertrewrite.py 84.04% <0%> (+1.46%) ⬆️
src/_pytest/pytester.py 91.17% <0%> (+5.35%) ⬆️
src/_pytest/_argcomplete.py 75% <0%> (+41.66%) ⬆️
testing/test_argcomplete.py 68.11% <0%> (+47.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ce586...3778881. Read the comment docs.

@nicoddemus nicoddemus merged commit b549438 into pytest-dev:features Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants