Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore usedevelop=True now that pip 19.1.1 restored the old behavior #5222

Merged
merged 1 commit into from May 7, 2019
Merged

Restore usedevelop=True now that pip 19.1.1 restored the old behavior #5222

merged 1 commit into from May 7, 2019

Conversation

nicoddemus
Copy link
Member

Fix #5167

asottile
asottile approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus nicoddemus merged commit d76735f into pytest-dev:master May 7, 2019
@nicoddemus nicoddemus deleted the restore-usedevelop branch May 7, 2019 13:01
@blueyed
Copy link
Contributor

blueyed commented May 14, 2019

Azure does not have/use pip 19.1.1 apparently? (for some envs only)
https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=1073&view=logs&jobId=e38d3164-b5f2-578d-f4d9-260ae069b587&taskId=8198004e-82e3-5b60-c14f-a5b1a78c79f7&lineStart=74&lineEnd=75&colStart=1&colEnd=1

@asottile
Copy link
Member

this is part of the changes in latest tox which defaults to the bundled version of pip w/ virtualenv instead of unconfigurably reaching to pypi for the latest version

we can opt into the unpinned behaviour by setting download=true on the testenv -- or I can bug @gaborbernat to make a virtualenv release with pip 19.1.1 😆

@asottile
Copy link
Member

actually, looks like that's already in motion! pypa/virtualenv@be82612

@gaborbernat
Copy link
Contributor

Doing the new release is a WIP... Will probably do it in the morning.

@nicoddemus nicoddemus mentioned this pull request May 14, 2019
Closed
@gaborbernat
Copy link
Contributor

Done via pypa/virtualenv#1357

@blueyed
Copy link
Contributor

blueyed commented May 15, 2019

Thanks!

@hackebrot hackebrot mentioned this pull request May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip 19.1 prevents pytest from being used in editable mode
4 participants
@nicoddemus @blueyed @asottile @gaborbernat