Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: restore tracing function #5406

Merged
merged 1 commit into from Jun 5, 2019
Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 5, 2019

Without this, testing/test_pdb.py (already without pexpect) will cause
missing test coverage afterwards (for the same process).

https://bugs.python.org/issue37011

Without this, `testing/test_pdb.py` (already without pexpect) will cause
missing test coverage afterwards (for the same process).
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #5406 into master will increase coverage by 2.21%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5406      +/-   ##
==========================================
+ Coverage   93.76%   95.98%   +2.21%     
==========================================
  Files         114      114              
  Lines       25489    25496       +7     
  Branches     2472     2474       +2     
==========================================
+ Hits        23901    24473     +572     
+ Misses       1275      718     -557     
+ Partials      313      305       -8
Impacted Files Coverage Δ
testing/conftest.py 90.32% <57.14%> (-9.68%) ⬇️
src/_pytest/config/__init__.py 94.33% <0%> (+0.64%) ⬆️
testing/test_pdb.py 99% <0%> (+0.79%) ⬆️
src/_pytest/python.py 93.03% <0%> (+0.85%) ⬆️
src/_pytest/pytester.py 91.02% <0%> (+0.88%) ⬆️
src/_pytest/terminal.py 93.06% <0%> (+1.41%) ⬆️
src/_pytest/tmpdir.py 100% <0%> (+3.7%) ⬆️
testing/python/fixtures.py 99.09% <0%> (+8.4%) ⬆️
testing/test_terminal.py 99.84% <0%> (+8.45%) ⬆️
testing/python/metafunc.py 94.88% <0%> (+18.73%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdc2d7...aab5687. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 5, 2019

Going to merge this as base for #5403 already.

@blueyed blueyed merged commit 190456a into pytest-dev:master Jun 5, 2019
@blueyed blueyed deleted the restore-tracing branch June 5, 2019 09:51
@blueyed blueyed added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jun 5, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Jun 5, 2019

Backport: #5408

@blueyed blueyed removed the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jun 5, 2019
@nicoddemus nicoddemus added needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants