Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply workaround for multiple short options for Python <= 3.8 #5526

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

nicoddemus
Copy link
Member

Hopefully by Python 3.9 this will be fixed upstream, if not we will
need to bump the version again.

Fix #5523

Hopefully by Python 3.9 this will be fixed upstream, if not we will
need to bump the version again.

Fix pytest-dev#5523
@nicoddemus
Copy link
Member Author

Just realized this, why are we not testing Python 3.8? 🤔

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #5526 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5526   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         117      117           
  Lines       25695    25695           
  Branches     2493     2493           
=======================================
  Hits        24696    24696           
  Misses        695      695           
  Partials      304      304
Impacted Files Coverage Δ
src/_pytest/config/argparsing.py 88.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a76a0...94a05e5. Read the comment docs.

@nicoddemus
Copy link
Member Author

Oh we run py38 as a cron job... not sure it is effective, hardly ever looks at the cron jobs, I'm afraid.

Made running py38 part of the standard jobs again, now that we have significantly reduced the build matrix on master.

@nicoddemus nicoddemus merged commit 497cd87 into pytest-dev:master Jun 29, 2019
@nicoddemus nicoddemus deleted the cmdline-shortopt branch June 29, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line parsing error with Python 3.8
2 participants