Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use identity checks for the mock sentinels #5631

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

RonnyPfannschmidt
Copy link
Member

fixes #5606

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #5631 into master will increase coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5631      +/-   ##
==========================================
+ Coverage   94.76%   96.12%   +1.35%     
==========================================
  Files         117      117              
  Lines       25770    25773       +3     
  Branches     2495     2493       -2     
==========================================
+ Hits        24422    24774     +352     
+ Misses       1030      695     -335     
+ Partials      318      304      -14
Impacted Files Coverage Δ
testing/python/integration.py 94.28% <100%> (+0.21%) ⬆️
src/_pytest/compat.py 98.5% <100%> (+1.44%) ⬆️
src/_pytest/pastebin.py 87.71% <0%> (-3.51%) ⬇️
testing/test_pytester.py 89.27% <0%> (+0.57%) ⬆️
src/_pytest/pytester.py 90.96% <0%> (+1.03%) ⬆️
src/_pytest/capture.py 94.75% <0%> (+1.31%) ⬆️
testing/test_terminal.py 99.84% <0%> (+1.4%) ⬆️
src/_pytest/terminal.py 93.02% <0%> (+2.27%) ⬆️
src/_pytest/unittest.py 94.97% <0%> (+5.58%) ⬆️
src/_pytest/debugging.py 90.05% <0%> (+20.41%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb828eb...8c7d912. Read the comment docs.

FOO = NumpyLike(10)
"""
)
testdir.syspathinsert()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testdir.syspathinsert is not necessary here (tested without it).

@blueyed
Copy link
Contributor

blueyed commented Jul 20, 2019

Please squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when collecting tests that patch an array
3 participants