Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.coveragerc: add report section #5747

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 15, 2019

This will allow for "raise NotImplementedError" to indicate code not to
be covered in tests etc.

@nicoddemus
Copy link
Member

Can you rebase on features please?

@blueyed
Copy link
Contributor Author

blueyed commented Aug 15, 2019

This is for master?!

Ok, why?

@blueyed
Copy link
Contributor Author

blueyed commented Aug 15, 2019

I have a pending commit for testing/python/fixtures.py to improve coverage there.

Wanted to compare this separately.

Can rebase it on features afterwards (but it is not clear to me why that should be done still).

This will allow for "raise NotImplementedError" to indicate code not to
be covered in tests etc.
@pytest-dev pytest-dev deleted a comment from codecov bot Aug 15, 2019
@nicoddemus
Copy link
Member

Can rebase it on features afterwards (but it is not clear to me why that should be done still).

I like to minimize the diff when making the release, but so be it. 🤷‍♂

@nicoddemus
Copy link
Member

Well actually this does not matter to the release at all, so in the end it is fine to have this in master. 👍

@asottile asottile merged commit ac3056c into pytest-dev:master Aug 15, 2019
@blueyed blueyed deleted the coveragerc-report branch August 16, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants