Show the mnemonic of pytest.ExitCode in RunResult's repr #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
approved these changes
Oct 22, 2019
src/_pytest/pytester.py
Outdated
| @@ -370,9 +370,13 @@ def __init__(self, ret, outlines, errlines, duration): | |||
| self.duration = duration | |||
|
|
|||
| def __repr__(self): | |||
| try: | |||
| ret = pytest.ExitCode(self.ret) | |||
There was a problem hiding this comment.
this should convert in the ctor instead
There was a problem hiding this comment.
Done, also changed from:
<RunResult ret=<ExitCode.TESTS_FAILED: 1> len(...
To:
<RunResult ret=ExitCode.TESTS_FAILED len(...
Because I believe it reads better.
nicoddemus
force-pushed
the
run-result-exit-code
branch
from
821bdc4
to
89fee55
Compare
bluetech
approved these changes
Oct 23, 2019
RonnyPfannschmidt
approved these changes
Oct 23, 2019
nicoddemus
force-pushed
the
run-result-exit-code
branch
from
89fee55
to
7beb520
Compare
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4901