Replace custom flask theme by the official one #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pages can be seen here: https://docs.pytest.org/en/use-standard-flask-theme/ |
|
not "perfect", but my first impression is a lot better |
nicoddemus
changed the title
Closed
nicoddemus
force-pushed
the
use-standard-flask-theme
branch
from
784f777
to
bfafaec
Compare
nicoddemus
changed the title
|
Since we didn't get traction in other fronts, I suggest we go ahead with this style: it is an updated flask theme at least, and already an improvement IMHO. We can always apply another theme later if we decide on a better one. What do you guys think? |
bluetech
approved these changes
May 31, 2020
RonnyPfannschmidt
approved these changes
May 31, 2020
|
Sounds good - thanks @nicoddemus! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6402