Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faulthandler: trylast=True #7025

Merged
merged 3 commits into from
Apr 9, 2020
Merged

faulthandler: trylast=True #7025

merged 3 commits into from
Apr 9, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 5, 2020

It should happen as late as possible before the test runs.

Ref: #7022

@blueyed
faulthandler: trylast=True
7100e62 
It should happen as late as possible before the test runs.

Ref: pytest-dev#7022
bluetech
bluetech reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, to only time the test itself as much as possible and not include surrounding hooks. But I'm not confident enough to approve myself. Feel free to ping me though and I will dig into it more.

@blueyed blueyed merged commit 413ca8a into pytest-dev:master Apr 9, 2020
@blueyed blueyed deleted the faulthandler-trylast branch April 9, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech left review comments

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blueyed @nicoddemus @bluetech