Feature/raises clearer guidance #7499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lewiscowles1986
force-pushed
the
feature/raises-clearer-guidance
branch
from
063beec
to
ab13c8b
Compare
nicoddemus
reviewed
Jul 14, 2020
There was a problem hiding this comment.
Thanks @Lewiscowles1986!
I did not follow the discussion originally, but I think this is an improvement.
Please see my comments and let us know what you think.
Lewiscowles1986
force-pushed
the
feature/raises-clearer-guidance
branch
from
ab13c8b
to
90afa50
Compare
nicoddemus
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Thanks @Lewiscowles1986, LGTM, but @asottile @RonnyPfannschmidt and @bluetech should also chime in. 👍
asottile
requested changes
Jul 14, 2020
Lewiscowles1986
force-pushed
the
feature/raises-clearer-guidance
branch
from
90afa50
to
360e4fb
Compare
bluetech
approved these changes
Jul 15, 2020
Thanks @bluetech Co-authored-by: Ran Benita <ran@unusedvar.com>
|
Thanks @Lewiscowles1986! |
blueyed
pushed a commit
to blueyed/pytest
that referenced
this pull request
Jul 15, 2020
(cherry picked from commit 71ab623)
|
Thanks @bluetech @asottile @nicoddemus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include documentation when adding new features.Fixes #7489
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. (pending)AUTHORSin alphabetical order. (pending)I need to work out the
did you meanpart. I see an example, but it seems to usemark. I did make my own version of the assertion, which fulfilled enough of a change to make me happy outside of pytest using__tracebackhide__ = Truewith a patchedcontextlibto avoid the class.Is some of the boilerplate for legacy python versions?