-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add naming convention defaults for nose and pytest #8502
Conversation
https://pytest--8502.org.readthedocs.build/en/8502/how-to/nose.html?highlight=nose#unsupported-idioms-known-issues <- looks like the legend is missing |
We also should rebase this after #8505 gets merged. 👍 |
Thanks @RonnyPfannschmidt
The symbols look fine for me. I'm using the Brave Browser on MacOS |
7fada98
to
36abe84
Compare
We still have build failures:
Seems like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
doc/en/how-to/nose.rst
Outdated
Ⓒ \*\(unittest.TestCase\) ✅ ✅ | ||
ⓜ test_\* ✅ ✅ | ||
Ⓒ Test\* ✅ | ||
ⓜ test_\* ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I'm missing something but isn't this the same as two lines above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with RST syntax, found this in the documentation Escaping Mechanism but I don't think it would serve me here. If you have any suggestions that would be great!
That explains a lot!😅 I tried a number of combinations of \ to escape them but to no avail. I'll try again later. |
This will work with non-breaking spaces:
And that’ll even work through LaTeX too. |
I pushed a small change, using an extra column so we can drop the symbols and legend, and using I'm sorry it's taken literal years to merge such a nice little PR - thanks for opening it, and for all your patience 😅 |
Introducing a small table with a legend detailing the default naming conventions used by
nose
andpytest
Based on the following discussion.
Adding the tables here: