Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prereleases from prepare-release workflow #8628

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

nicoddemus
Copy link
Member

Unfortunately untested, as it is only available once it lands on main.

Fix #7551

.github/workflows/prepare-release-pr.yml Outdated Show resolved Hide resolved
.github/workflows/prepare-release-pr.yml Outdated Show resolved Hide resolved
@The-Compiler
Copy link
Member

@nicoddemus What are your plans on this? If we want a 7.0.0rc1 (or 6.3.0rc1), we should probably get this in first.

@nicoddemus
Copy link
Member Author

Argh completely missed this one.

I'm not sure I will be able to get to this today (I'll do my best), but if anybody wants to take this please go ahead. 👍

@nicoddemus
Copy link
Member Author

Applied @asottile's suggestions. 👍

Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Fingers crossed that it won't fail in some way which is totally obvious in hindsight but we all missed somehow 🙈

@The-Compiler The-Compiler enabled auto-merge (squash) June 24, 2021 17:50
@nicoddemus
Copy link
Member Author

Fingers crossed that it won't fail in some way which is totally obvious in hindsight but we all missed somehow

Heh ditto! 😁

@The-Compiler The-Compiler merged commit 0d6cb3b into pytest-dev:main Jun 24, 2021
@The-Compiler
Copy link
Member

Hmm wait, I think this is only a part of the equation, though? At least according to RELEASING.rst we're still triggering @pytestbot via a release comment (rather than triggering the workflow manually), so release-on-comment.py would need an update to support something like a @pytestbot please prepare [major] prerelease from ... too, no?

@nicoddemus
Copy link
Member Author

t least according to RELEASING.rst we're still triggering @pytestbot via a release comment (rather than triggering the workflow manually)

Those are not up to date, we have made the last two releases (or so) with this new workflow, I think we can remove the release-on-comment one as obsolete. 👍

@nicoddemus nicoddemus deleted the prereleases-7551 branch June 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release-on-comment script to handle release candidates
3 participants