-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow prereleases from prepare-release workflow #8628
Conversation
@nicoddemus What are your plans on this? If we want a 7.0.0rc1 (or 6.3.0rc1), we should probably get this in first. |
Argh completely missed this one. I'm not sure I will be able to get to this today (I'll do my best), but if anybody wants to take this please go ahead. 👍 |
116ab3d
to
c19c675
Compare
Applied @asottile's suggestions. 👍 |
c19c675
to
c360d7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Fingers crossed that it won't fail in some way which is totally obvious in hindsight but we all missed somehow 🙈
Heh ditto! 😁 |
Hmm wait, I think this is only a part of the equation, though? At least according to RELEASING.rst we're still triggering @pytestbot via a release comment (rather than triggering the workflow manually), so release-on-comment.py would need an update to support something like a |
Those are not up to date, we have made the last two releases (or so) with this new workflow, I think we can remove the |
Unfortunately untested, as it is only available once it lands on
main
.Fix #7551