Add legacypath plugin, move py.path stuff there #9208
Conversation
bluetech
force-pushed
the
legacypath-plugin
branch
from
f0b29e2
to
85945cb
Compare
|
This is great work so far! |
|
This looks lovely, I'll give it a spin once I get Better from the cold |
bluetech
force-pushed
the
legacypath-plugin
branch
from
85945cb
to
2b0aabc
Compare
|
Rebased, now uses the public exported |
bluetech
force-pushed
the
legacypath-plugin
branch
from
2b0aabc
to
301c830
Compare
bluetech
changed the title
bluetech
force-pushed
the
legacypath-plugin
branch
from
301c830
to
c3dff75
Compare
|
I fixed the docs generation and improved the coverage a bit (though not for One thing is that the
I can think of ways to fix this but I don't think they're worth it, so I'm inclined to just leave it as is. Regarding the changelog and docs, I'd like to add them in a separate PR, as part of making the entire py.path deprecation more cohesive. So I'm marking the PR as ready. |
src/_pytest/legacypath.py
Outdated
| def tmpdir_factory(request: pytest.FixtureRequest) -> TempdirFactory: | ||
| """Return a :class:`pytest.TempdirFactory` instance for the test session.""" | ||
| # Set dynamically by pytest_configure(). | ||
| return request.config._tmpdirhandler # type: ignore |
There was a problem hiding this comment.
lets make a plugin class that adds those 2 and gets installed in pytest_configure, that way that part is handed more correct
There was a problem hiding this comment.
Can you expand "those 2" and "that part" -- I'm not sure I get what they refer to.
There was a problem hiding this comment.
sorry i missplaced my commment - i meant the testdir fixture
if its only added when the pytester plugin is enabled, it should be fine
There was a problem hiding this comment.
I can do it by moving to a separate plugin in a separate file, otherwise I don't know how to prevent @pytest.fixture from doing its thing, i.e. how to add the fixture dynamically. And I thought that was a bit too much, for something that users are not very likely to hit, and would only result in a slightly less clear error message.
There was a problem hiding this comment.
@bluetech a plugin an just be a class - so if that particular fixture jsut goes to a class no new file is needed
There was a problem hiding this comment.
For some reason I thought @pytest.fixture has a more global effect, even though I know it doesn't.
I pushed a commit which does this, PTAL.
… plugins are registered This preserves the existing behavior and gives a proper error message in case e.g. `testdir` is requested without the `pytester` plugin being loaded.
This is part of issue #7259. The idea is that eventually all remaining
py.pathdependency will be in this plugin, and it could be phased out from core into an external plugin, and pytest could remove the dependency on py, while providing users a way to restore compatibility.I managed to move everything to the plugin, except two things, which I don't think can be:
Both of these things mostly affect plugins, not really user test suites, so I think deprecation+removal of them is reasonable.
Note: if the plugin is not loaded, all of the tests pass, except
test_legacypath.pytests.This is marked WIP as there as few things I need to do before this can be merged (plugin deps, changelog, docs), but comments are welcome.
For comparison, I rebased my branch which removed py completely, which I used as reference: https://github.com/bluetech/pytest/commits/rm-py