Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing ID if actual contracts #7

Closed
ali-bahjati opened this issue Mar 4, 2022 · 1 comment
Closed

Exposing ID if actual contracts #7

ali-bahjati opened this issue Mar 4, 2022 · 1 comment

Comments

@ali-bahjati
Copy link
Collaborator

declare_id exposes ids publicly and it might be misleading for users. It is a practice in sdks that they include their contract ID and consumers often check with that. In Pyth usecase it is unlikely that a consumer do that because usually they initialize their contracts with correct price account key and check against that.

We can keep it as it is, or move out test contract, or make it mainnet/devnet id.

@ali-bahjati
Copy link
Collaborator Author

Since we are not exposing it now I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant