Keep output as native string so we can compatible with python2 interface #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. open() return string on both python2 and python3, just keep it.
2. stdout of Popen() return string on python2, and bytes on python3,
decode to string.
lisongmin
force-pushed
the
keep-output-as-native-str
branch
from
f8af582
to
da027a8
Compare
nir0s
approved these changes
Mar 30, 2020
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 6, 2020
## 1.5.0 (2020.3.30) BACKWARD COMPATIBILITY: * Keep output as native string so we can compatible with python2 interface [[#248](python-distro/distro#248)] ENHANCEMENTS: BUG FIXES: * Fix detection of RHEL 6 ComputeNode [[#255](python-distro/distro#255)] * Fix Oracle 4/5 lsb_release id and names [[#250](python-distro/distro#250)] * Ignore /etc/plesk-release file while parsing distribution [[#246](python-distro/distro#246)] TESTS: * Test on MidnightBSD [[#254](python-distro/distro#254)] RELEASE: * Remove build testing on Python 3.3 and add pypy 3.5 and Python 3.7 and 3.8 [[#244](python-distro/distro#244)] * Fix Windows build due to Appveyor not supporting builds on Python 2.7 anymore [[#257](python-distro/distro#257)] Additionally, The Python2.6 branch was fixed to support distro version 1.4.0. It is now passing all tests. Thanks [abadger](https://github.com/abadger)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since
platform.linux_distribution()returns tuple of str， we should compatible with the same behavior on both python2 and python3.decode to string.