Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #244

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Improve testing #244

merged 2 commits into from
Mar 30, 2020

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Aug 14, 2019

Hello @nir0s,

I believe that it would be nice to have tests for actual and upcoming Python versions.

These changes also:

  • declare support for Python 3.7 and 3.8 at setup.py
  • remove Python 3.3 from tox's envlist
  • remove deprecated sudo option from .travis.yml
  • fix typos

Best regards!

tests/test_distro.py Outdated Show resolved Hide resolved
@nir0s
Copy link
Collaborator

nir0s commented Aug 19, 2019

@Jamim LGTM. Please rebase on top of master.

@Jamim
Copy link
Contributor Author

Jamim commented Aug 19, 2019

Hello @nir0s,

Please rebase on top of master.

It's done.

@Jamim
Copy link
Contributor Author

Jamim commented Aug 19, 2019

It looks like Codecov checks got stuck for some reason.

@Jamim
Copy link
Contributor Author

Jamim commented Aug 28, 2019

ping @nir0s

I believe that it would be nice to have tests
for actual and upcoming Python versions.

These changes also:

 - declare support for Python 3.7 and 3.8 at setup.py

 - remove Python 3.3 from tox's envlist

 - remove deprecated sudo option from .travis.yml

 - fix typos
@nir0s nir0s merged commit c6c316e into python-distro:master Mar 30, 2020
@Jamim Jamim deleted the feature/improve-testing branch March 31, 2020 10:46
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 6, 2020
## 1.5.0 (2020.3.30)

BACKWARD COMPATIBILITY:
* Keep output as native string so we can compatible with python2 interface [[#248](python-distro/distro#248)]

ENHANCEMENTS:

BUG FIXES:
* Fix detection of RHEL 6 ComputeNode [[#255](python-distro/distro#255)]
* Fix Oracle 4/5 lsb_release id and names [[#250](python-distro/distro#250)]
* Ignore /etc/plesk-release file while parsing distribution [[#246](python-distro/distro#246)]

TESTS:
* Test on MidnightBSD [[#254](python-distro/distro#254)]

RELEASE:
* Remove build testing on Python 3.3 and add pypy 3.5 and Python 3.7 and 3.8 [[#244](python-distro/distro#244)]
* Fix Windows build due to Appveyor not supporting builds on Python 2.7 anymore [[#257](python-distro/distro#257)]

Additionally, The Python2.6 branch was fixed to support distro version 1.4.0. It is now passing all tests. Thanks [abadger](https://github.com/abadger)!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants