-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing #244
Merged
Merged
Improve testing #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostofGoes
reviewed
Aug 15, 2019
Jamim
force-pushed
the
feature/improve-testing
branch
from
August 15, 2019 10:08
9eae604
to
7476f09
Compare
GhostofGoes
approved these changes
Aug 19, 2019
@Jamim LGTM. Please rebase on top of master. |
Jamim
force-pushed
the
feature/improve-testing
branch
from
August 19, 2019 13:16
7476f09
to
13455b9
Compare
Hello @nir0s,
It's done. |
It looks like Codecov checks got stuck for some reason. |
ping @nir0s |
I believe that it would be nice to have tests for actual and upcoming Python versions. These changes also: - declare support for Python 3.7 and 3.8 at setup.py - remove Python 3.3 from tox's envlist - remove deprecated sudo option from .travis.yml - fix typos
Jamim
force-pushed
the
feature/improve-testing
branch
from
October 16, 2019 22:38
13455b9
to
b46c337
Compare
nir0s
approved these changes
Mar 30, 2020
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 6, 2020
## 1.5.0 (2020.3.30) BACKWARD COMPATIBILITY: * Keep output as native string so we can compatible with python2 interface [[#248](python-distro/distro#248)] ENHANCEMENTS: BUG FIXES: * Fix detection of RHEL 6 ComputeNode [[#255](python-distro/distro#255)] * Fix Oracle 4/5 lsb_release id and names [[#250](python-distro/distro#250)] * Ignore /etc/plesk-release file while parsing distribution [[#246](python-distro/distro#246)] TESTS: * Test on MidnightBSD [[#254](python-distro/distro#254)] RELEASE: * Remove build testing on Python 3.3 and add pypy 3.5 and Python 3.7 and 3.8 [[#244](python-distro/distro#244)] * Fix Windows build due to Appveyor not supporting builds on Python 2.7 anymore [[#257](python-distro/distro#257)] Additionally, The Python2.6 branch was fixed to support distro version 1.4.0. It is now passing all tests. Thanks [abadger](https://github.com/abadger)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nir0s,
I believe that it would be nice to have tests for actual and upcoming Python versions.
These changes also:
setup.py
tox
'senvlist
sudo
option from.travis.yml
Best regards!