Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron-Eel Idea #35

Closed
abulka opened this issue Mar 24, 2018 · 2 comments
Closed

Electron-Eel Idea #35

abulka opened this issue Mar 24, 2018 · 2 comments

Comments

@abulka
Copy link

abulka commented Mar 24, 2018

Love this project, however I discovered a few downsides in the deployment dept.

  • Requires chrome browser to be installed by the user in the target system
  • Packaging with PyInstaller works but displays a console window when launched. Attempting to specify no console causes app to launch and immediately disappear (still investigating this, but many people have encountered it e.g. Mac --windowed .app Not Clickable, Runs From Console pyinstaller/pyinstaller#1804)
  • There are no native menus, open file dialog boxes etc. I can't for example browse for a file in the UI and get its full pathname returned to me (browser sandbox restrictions). I can't create professional menus.

I'm wondering if a version of this project could be adapted to work with Electron, using Eel's websocket approach instead of the zerorpc approach taken by https://github.com/fyears/electron-python-example. I'm finding the latter project powerful but its dependence on zerorpc makes it tricky to deploy.

Plus there are Electric eels, aren't there? Thoughts?

@ChrisKnott
Copy link
Collaborator

ChrisKnott commented Apr 3, 2018

@abulka Thanks for checking out the project!

To get rid of the console window, include the '--noconsole' flag when you are packaging. This is mentioned in the README but it is hidden away at the bottom.

Your other points are very valid, hopefully we will add support for other browsers in the future, particularly Firefox, after that I will look at better integration with Electron front end. In the meantime there are several libraries that can recreate menu bars such Bootstrap and jQueryUI, combining this with calls into Python you should be able to achieve Save/Load behaviour close to native.

@ChrisKnott
Copy link
Collaborator

@abulka It's possible to use Electron as the front end with the new custom mode. See #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants