Merge pull request #1213 from python-gitlab/fix/delete-attr

fix(base): really refresh object
python-gitlab · Oct 13, 2020 · af965d4 · af965d4
2 parents ce8460f + e1e0d8c
commit af965d4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/gitlab/base.py b/gitlab/base.py
@@ -131,7 +131,7 @@ def _create_managers(self):
 
     def _update_attrs(self, new_attrs):
         self.__dict__["_updated_attrs"] = {}
-        self.__dict__["_attrs"].update(new_attrs)
+        self.__dict__["_attrs"] = new_attrs
 
     def get_id(self):
         """Returns the id of the resource."""

diff --git a/gitlab/tests/test_base.py b/gitlab/tests/test_base.py
@@ -128,6 +128,13 @@ def test_update_attrs(self, fake_manager):
         assert {"foo": "foo", "bar": "bar"} == obj._attrs
         assert {} == obj._updated_attrs
 
+    def test_update_attrs_deleted(self, fake_manager):
+        obj = FakeObject(fake_manager, {"foo": "foo", "bar": "bar"})
+        obj.bar = "baz"
+        obj._update_attrs({"foo": "foo"})
+        assert {"foo": "foo"} == obj._attrs
+        assert {} == obj._updated_attrs
+
     def test_create_managers(self, fake_gitlab, fake_manager):
         class ObjectWithManager(FakeObject):
             _managers = (("fakes", "FakeManager"),)