Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate outgoing request methods #85

Open
njsmith opened this issue Jun 5, 2019 · 1 comment
Open

Validate outgoing request methods #85

njsmith opened this issue Jun 5, 2019 · 1 comment

Comments

@njsmith
Copy link
Member

njsmith commented Jun 5, 2019

Twisted recently did a CVE fix for CRLF injection in methods and request targets: https://twistedmatrix.com/trac/ticket/9647

We already validate request targets and headers to prevent this kind of nonsense, but AFAICT we don't actually validate request methods.

It seems very unlikely that most people are allowing attacker-controlled input into their HTTP methods. Methods are hard-coded like 99.999% of the time. But given that we're already validating everything else, we might as well validate this too just to make sure.

@sigmavirus24
Copy link

I wonder if there's a need to provide an escape hatch as well for projects like pathod that might be using h11 to do non-standard things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants