Merge pull request #83 from fredthomsen/MemoryViewInDataFrame

Handle memory view serialization in data frame

CONTRIBUTORS.rst

@@ -50,3 +50,7 @@ In chronological order:
 
   - Performance improvements to serialization and parsing.
 
+- Fred Thomsen (@fredthomsen)
+
+  - Support for memoryview in DataFrames.
+

HISTORY.rst

@@ -4,6 +4,10 @@ Release History
 6.0.0dev0
 ---------
 
+**API Changes (Backward-compatible)**
+
+- Added support for ``DataFrame.data`` being a ``memoryview`` object.
+
 5.0.0 (2017-03-07)
 ------------------
 

hyperframe/frame.py

@@ -270,6 +270,8 @@ def __init__(self, stream_id, data=b'', **kwargs):
     def serialize_body(self):
         padding_data = self.serialize_padding_data()
         padding = b'\0' * self.total_padding
+        if isinstance(self.data, memoryview):
+            self.data = self.data.tobytes()
         return b''.join([padding_data, self.data, padding])
 
     def parse_body(self, data):

test/test_frames.py

@@ -113,10 +113,14 @@ def test_data_frame_has_correct_flags(self):
             'END_STREAM', 'PADDED'
         ])
 
-    def test_data_frame_serializes_properly(self):
+    @pytest.mark.parametrize('data', [
+        b'testdata',
+        memoryview(b'testdata')
+    ])
+    def test_data_frame_serializes_properly(self, data):
         f = DataFrame(1)
         f.flags = set(['END_STREAM'])
-        f.data = b'testdata'
+        f.data = data
 
         s = f.serialize()
         assert s == self.payload