fix test for non utc systems. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strict_rfc3339.rfc3339_to_timestamp()` is tz aware `datetime.datetime.fromtimestamp` is not this causes the test `test_string_format_datetime` to fail on system that are not on utc
berend
force-pushed
the
bugfix/fix_test_for_non_utc
branch
from
02ed40f
to
f08257b
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 54 54
Lines 1441 1441
=======================================
Hits 1388 1388
Misses 53 53
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 54 54
Lines 1441 1441
=======================================
Hits 1388 1388
Misses 53 53
Continue to review full report at Codecov.
|
|
@berend thank you for the contribution. |
bjmc
pushed a commit
to bjmc/openapi-core
that referenced
this pull request
Jun 12, 2019
…_non_utc fix test for non utc systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strict_rfc3339.rfc3339_to_timestamp()is tz awaredatetime.datetime.fromtimestampis notthis causes the test
test_string_format_datetimeto fail onsystem that are not on utc