Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.1 Release Issue #2492

Closed
wiredfool opened this issue Apr 19, 2017 · 5 comments
Closed

4.1.1 Release Issue #2492

wiredfool opened this issue Apr 19, 2017 · 5 comments
Labels
Milestone

Comments

@wiredfool
Copy link
Member

wiredfool commented Apr 19, 2017

So, 4.1.0 has settled for a bit, and I think that a 4.1.1 release is appropriate for the Exif/Dpi (#2484) issue and the Python 3.6.0/1 (#2479) issue.

I've had a look at https://bugs.python.org/issue29943 again, and I'm not sure where the resolution of this is going to fall, but I'm leaning to some sort of workaround on our end, either a friendly notification or undefining the symbol. (Though, the undefining solution is going to live on far past the eventual resolution in Python)

As a sort of delayed post-mortem for the 4.1.0 release, it's becoming clear that no one installing our code is really prepared to do the compilation. Binaries are the thing, and we'd save support issues by pushing the new release to pypi all in one shot, rather than as source, then two or three different sets of binaries.

So, if @cgohlke is ok with it, I'd like to change the release procedure to:

  • Prepare release, bump versions and such.
  • Run the osx/linux wheels
  • Tag & notify @cgohlke for windows binaries
  • Upload sdist, mac, linux, and windows wheels in one shot.

I don't know if @cgohlke is pulling from pypi, or git checkout or zips or what -- so that's the uncertainty in this plan.

@wiredfool wiredfool added this to the 4.1.1 milestone Apr 19, 2017
@aclark4life
Copy link
Member

+1, I'm fairly certain @cgohlke can grab the source from GitHub to build binaries but you're right we should confirm that.

@cgohlke
Copy link
Contributor

cgohlke commented Apr 19, 2017

A tag on GitHub is OK.

@wiredfool
Copy link
Member Author

k, tagged 4.1.1 and pushed on pillow wheels.

@wiredfool
Copy link
Member Author

Many thanks @cgohlke

@wiredfool
Copy link
Member Author

And they're up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants