Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageFont.truetype: error in windows fonts fallback #294

Closed
ghost opened this issue Jul 22, 2013 · 4 comments
Closed

ImageFont.truetype: error in windows fonts fallback #294

ghost opened this issue Jul 22, 2013 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 22, 2013

There is a small issue in Windows fall back in ImageFont.truetype (lines 246-248)

if windir:
    filename = os.path.join(windir, "fonts", font)
    return FreeTypeFont(font, size, index, encoding)

Second line should read

return FreeTypeFont(filename, size, index, encoding)

(PIL-1.1.7 has this right)
@aclark4life
Copy link
Member

Thanks, can you send a pull request?

@ghost
Copy link
Author

ghost commented Jul 22, 2013

Sure, let me understand my way around here as I'm new to Git and GitHub ;)

@aclark4life
Copy link
Member

Great! One easy way: fork Pillow then edit through the web, then send pull request

@wiredfool
Copy link
Member

closed by #295

radarhere pushed a commit to radarhere/Pillow that referenced this issue Sep 24, 2023
@hugovk
Merge pull request python-pillow#294 from radarhere/openjpeg
3378ab4 
Updated openjpeg to 2.5.0 on macOS x86_64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wiredfool @aclark4life