Use landscape.io instead of running lint tools with the build

[thedrow]

landscape.io allows you to track code quality over time and it runs multiple tools.
It's easily configureable and free for open source.
It will also allow free some build time for PRs since the entire lint process is done outside of travis.

What do you guys think?

[hugovk]

Looks interesting, I'll check it out. Thanks!

[hugovk]

I've added Pillow to Landscape and the first result (with defaults) is "100% Excellent!"

https://landscape.io/github/python-pillow/Pillow/1

I'll have a look a bit further around the config, because at least pep8 and pyflakes on Travis report some things, which I don't see on Landscape by default. Anyway, I've added a badge to the README.

[hugovk]

On my branch, I added a .landscape.yaml config file and did a build to include warnings for tests, and then increased strictness from default medium to high and very high but still got 100% health.

https://landscape.io/github/hugovk/Pillow/landscape

Here's the different profiles for each strictness, and we should definitely be getting something less than 100%:

https://github.com/landscapeio/prospector/blob/master/prospector/profiles/profiles/strictness_medium.yaml
https://github.com/landscapeio/prospector/blob/master/prospector/profiles/profiles/strictness_high.yaml
https://github.com/landscapeio/prospector/blob/master/prospector/profiles/profiles/strictness_veryhigh.yaml

[thedrow]

We should remove the flake and lint check from the build if this is accepted.
You got 100% health since the CI process was checking some of it anyway.

[hugovk]

There may be a benefit in leaving them in Travis as well because there seems to be some delay in Landscape running. Also, they might produce different output on different Python versions.

You got 100% health since the CI process was
checking some of it anyway.

I don't understand. Are you saying Landscape reports 100% percent because it's inspecting Travis CI and can see we're running pep8 and pyflakes so ignores those? I doubt it, as we'd definitely see lots of pylint warnings.

[thedrow]

I'm saying that since the build didn't fail I assumed that there are no lint errors/warnings.

[hugovk]

Oh, there are definitely plenty of pep8 and pyflakes warnings at the end of the Travis logs, but they don't (and we don't want them to) cause the build to fail.

[thedrow]

Can you enable landscape.io on the main repo so we can evaluate it over time (with each new commit)?

[hugovk]

It already is :)

But it's not working yet due to a bug in a dependency. Reported here: landscapeio/landscape-issues#70

[thedrow]

Oh wow. That's a hell of an edgecase.

[thedrow]

After the badge is reintroduced this issue should be closed.