Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] added PySide compability #1024

Merged
merged 2 commits into from
Nov 27, 2014
Merged

[ADD] added PySide compability #1024

merged 2 commits into from
Nov 27, 2014

Conversation

holg
Copy link
Contributor

@holg holg commented Nov 20, 2014

Added import statements for PySide for PySide comp ability

@wiredfool
Copy link
Member

I'm worried about testing this -- PySide appears to be a pretty big set of dependencies to install on travis each time, and they don't ship binaries for linux.

@holg
Copy link
Contributor Author

holg commented Nov 21, 2014

Well i agree, specially it is not easy to have those different Versions and kind of QT stuff,
pillow starts to test for PyQt5, then looks up PyQt4, so now this commit adds another to lookup PySide,
i would not think to much about testing this, in the end no source code in pillow should be changed, since PyQt4 and PySide do it the same way (regarding to the needs of pillow), so testing the one would be enough, i am always trying to keep my code compatible for both, in the end PySide has some advantages for using in cx_freeze and other packaging, whereas at all i would prefer PyQt5

@hugovk
Copy link
Member

hugovk commented Nov 21, 2014

At the moment we're only testing PyQt4 on the 2.7_with_system_site_packages environment.

@holg
Copy link
Contributor Author

holg commented Nov 22, 2014

ok, so how do you check PyQt5 ?
anyway i forgot to also adapt Tests/test_image_qt.py to pass tests in PySide environment

@wiredfool
Copy link
Member

We don't continually test PyQt5, and I'm not all that happy about that situation.

wiredfool added a commit that referenced this pull request Nov 27, 2014
[ADD] added PySide compability
@wiredfool wiredfool merged commit 9f7ee1c into python-pillow:master Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants