Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow truetype() to search for extensions other than .ttf #1117

Merged
merged 3 commits into from Apr 1, 2015

Conversation

radarhere
Copy link
Member

After the discussion in #1115, this allows truetype() to search for extensions other than .ttf if no extension is provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6686a84 on radarhere:master into * on python-pillow:master*.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 75.07% when pulling 3e9e95b on radarhere:master into d25a8d7 on python-pillow:master.

@radarhere radarhere force-pushed the master branch 2 times, most recently from c48bd1a to d3a6ee6 Compare March 26, 2015 01:55
@aclark4life
Copy link
Member

Can this go in before and/or without #1115 ?

@aclark4life aclark4life added this to the 2.8.0 milestone Apr 1, 2015
@radarhere
Copy link
Member Author

These commits are intended to be instead of #1115, so yes, it can go without that.

@aclark4life
Copy link
Member

Got it, thanks. Any chance for a test to accompany this?

@radarhere radarhere force-pushed the master branch 3 times, most recently from b34c8d6 to fec3f1c Compare April 1, 2015 04:08
@radarhere
Copy link
Member Author

So, in addition to the existing test for finding a TTF font with the extension specified, there are now tests for finding a TTF font without the extension specified, finding a non-TTF font without the extension specified and a test for preferring TTF over other extensions if there is no extension specified.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b75ee4c on radarhere:master into * on python-pillow:master*.

aclark4life added a commit that referenced this pull request Apr 1, 2015
Allow truetype() to search for extensions other than .ttf
@aclark4life aclark4life merged commit c91768f into python-pillow:master Apr 1, 2015
@aclark4life
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants