New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added copy method font_variant() and accessible properties to truetype() #1123
Conversation
Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*. |
3 similar comments
Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*. |
Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*. |
Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*. |
+1, I'm ok with this once there's documentation for the new method. |
Is this what you were after? As far as I can see, there isn't documentation for FreeTypeFont methods in docs/reference/ImageFont.rst |
Added copy method font_variant() and accessible properties to truetype()
Thanks. |
Strange, the CI failed after merging with:
The PR didn't pick it up because of the [CI skip], and I wouldn't have expected it to fail either. In general, I suppose if source code is edited at all, it's better to avoid CI skip! :) Fixup PR: #1143. |
Wow. Thanks! I was just unfamiliar with the Pillow/PIL codebase and didn't know what was going on. |
This is from the suggestion in issue #589
The original poster seemed to think it would be a complex change. I can't see why, so let me know if I have missed something.