Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copy method font_variant() and accessible properties to truetype() #1123

Merged
merged 2 commits into from Mar 21, 2015

Conversation

radarhere
Copy link
Member

This is from the suggestion in issue #589

The original poster seemed to think it would be a complex change. I can't see why, so let me know if I have missed something.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*.

3 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7a798f8 on radarhere:font_variant into * on python-pillow:master*.

@wiredfool
Copy link
Member

+1, I'm ok with this once there's documentation for the new method.

@radarhere
Copy link
Member Author

Is this what you were after? As far as I can see, there isn't documentation for FreeTypeFont methods in docs/reference/ImageFont.rst

hugovk added a commit that referenced this pull request Mar 21, 2015
Added copy method font_variant() and accessible properties to truetype()
@hugovk hugovk merged commit cabbc5d into python-pillow:master Mar 21, 2015
@hugovk
Copy link
Member

hugovk commented Mar 21, 2015

Thanks.

@hugovk
Copy link
Member

hugovk commented Mar 21, 2015

Strange, the CI failed after merging with:

TabError: inconsistent use of tabs and spaces in indentation
https://travis-ci.org/python-pillow/Pillow/builds/55271699

The PR didn't pick it up because of the [CI skip], and I wouldn't have expected it to fail either. In general, I suppose if source code is edited at all, it's better to avoid CI skip! :)

Fixup PR: #1143.

hugovk added a commit that referenced this pull request Mar 21, 2015
@radarhere radarhere deleted the font_variant branch March 21, 2015 09:53
@jvanasco
Copy link

jvanasco commented Apr 1, 2015

Wow. Thanks! I was just unfamiliar with the Pillow/PIL codebase and didn't know what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants