-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OleFileIO Upgrade #1226
OleFileIO Upgrade #1226
Conversation
Is it possible to backport all Pillow changes back to olefile? |
Most of the changes look ok, except a couple (4c5d4bf and 082a311): olefile should not rely on other Pillow modules (i.e. PIL._binary and _util) because it is also used as a standalone package by several other projects. This is only for a few small functions, so I would prefer to keep the code as-is for i8, i16, i32 and isPath. Apart from that, I am ok to backport the rest upstream. |
Because olefile is now installable via PyPI, should Pillow install it as a dependency instead? It'd make version updating much simpler, but what are the other benefits and drawbacks? |
@hugovk Probably not, unless Pillow could not be installed without it. How about removing it completely from Pillow and documenting |
@radarhere Please can you remove those things #1226 (comment) so standalone olefile isn't dependent on Pillow? |
dfb1248
to
ce60fc0
Compare
Sure thing. I've now removed those commits. However, I have also updated the methods so that Python performs the endian tasks as with the current version of _binary. |
ce60fc0
to
31e5fe8
Compare
31e5fe8
to
a662a94
Compare
Thank you! |
Upgrades OleFileIO to from 0.30 to the current version, 0.42b.
This series of commits, completely overwriting the existing version and then applying Pillow's local changes individually, was the cleanest way that I could think of.