Corrected version number when saving GIFs #1379
Closed
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
gifversion
branch
5 times, most recently
from
78f00bc
to
9f77b6e
Compare
| break | ||
| else: | ||
| if im.info.get("version") == "89a": | ||
| version = b"89a" |
There was a problem hiding this comment.
We got test coverage drop report, I can suggest to move this to separate unit and add simple unit test for it. But yeah, I know that project's layout is not very friendly to create new functions. Also please let me know if you need my help.
There was a problem hiding this comment.
I've just added a specific test. You're welcome to help out if you want to, but I will get it working sooner or later.
Merged
|
Combined into #1384 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #1355. GifImagePlugin has the output version number fixed a 87a, but may use features that are only valid for 89a.
http://www.w3.org/Graphics/GIF/spec-gif89a.txt
"The specification given here defines version 89a, which is an extension of version 87a."
The features that require 89a are -
"An encoder should use the earliest possible version number that includes all the blocks used in the Data Stream."
I think that this sounded reasonable in 1990, but today, both versions of GIF would be supported on a given platform. My suggestion is - if 89a features are used, then 89a. Otherwise, if the input has a version, use that. Otherwise, 87a.
This PR makes that change.