New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed history #1533
Removed history #1533
Conversation
I find these things quite interesting, and it doesn't really affect the code much. We also don't have commit history before the PIL->Pillow fork (although it's probably in some BitBucket repo somewhere). It's nice to see reminders this code is 20 years old! |
So we have @hugovk against, @wiredfool for in #1520 -
I'm fairly neutral on the issue, so if anyone feels strongly enough to close, feel free. Anyone else have any thoughts? |
Changes Unknown when pulling dd2b741 on radarhere:history into * on python-pillow:master*. |
44db80d
to
1e78262
Compare
I'm for deleting the history. I'm for deleting any stuff not related to the code from the code: history, licences, end of files. I'd like to see only useful comments explaining how this code works. For other things, there are LICENCE, CHANGES.rst and documentation.
We can't just turn codebase to the museum. What if we need to remove some file entirely (the question only for C files. We can't just delete python module for compatibility reasons)? Should we keep it just for the banner? I think it is better to collect all of them in some place outside of the code. |
We need to be way more careful with anything associated with licences and copyright notices than anything else that we're dealing with here. As for removal, I've dropped Incremental.c completely. (granted that's more recent than PIL 1.1.7) (edit: oh hey, I've mentioned copyright and licence before in this thread (sort of)) |
I definitely don't want to remove history without some extremely compelling argument … which I don't see here yet. |
Marking ready for merge + wontfix, please reopen if you think it's a serious problem to leave it in. Thanks |
#1520 contains the suggestion of removing history from Pillow files, so it is as a PR for consideration.