Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed history #1533

Closed
wants to merge 1 commit into from
Closed

Removed history #1533

wants to merge 1 commit into from

Conversation

radarhere
Copy link
Member

#1520 contains the suggestion of removing history from Pillow files, so it is as a PR for consideration.

@hugovk
Copy link
Member

hugovk commented Dec 9, 2015

I find these things quite interesting, and it doesn't really affect the code much. We also don't have commit history before the PIL->Pillow fork (although it's probably in some BitBucket repo somewhere). It's nice to see reminders this code is 20 years old!

@radarhere
Copy link
Member Author

So we have @hugovk against, @wiredfool for in #1520 -

I'd actually prefer to kill the changelog banner on all the files, since it's so out of
date on anything that we're actually working on. The only thing it's actually useful
for is determining which prehistoric layer of PIL the file is actually from.

Probably only retain a license and any copyright info, but I'd have to spot check
more to see if there's any other useful info there.

I'm fairly neutral on the issue, so if anyone feels strongly enough to close, feel free. Anyone else have any thoughts?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling dd2b741 on radarhere:history into * on python-pillow:master*.

@homm
Copy link
Member

homm commented Jul 4, 2016

I'm for deleting the history. I'm for deleting any stuff not related to the code from the code: history, licences, end of files. I'd like to see only useful comments explaining how this code works. For other things, there are LICENCE, CHANGES.rst and documentation.

It's nice to see reminders this code is 20 years old!

We can't just turn codebase to the museum. What if we need to remove some file entirely (the question only for C files. We can't just delete python module for compatibility reasons)? Should we keep it just for the banner? I think it is better to collect all of them in some place outside of the code.

@wiredfool
Copy link
Member

wiredfool commented Jul 5, 2016

We need to be way more careful with anything associated with licences and copyright notices than anything else that we're dealing with here.

As for removal, I've dropped Incremental.c completely. (granted that's more recent than PIL 1.1.7)

(edit: oh hey, I've mentioned copyright and licence before in this thread (sort of))

@aclark4life
Copy link
Member

I definitely don't want to remove history without some extremely compelling argument … which I don't see here yet.

@aclark4life
Copy link
Member

Marking ready for merge + wontfix, please reopen if you think it's a serious problem to leave it in. Thanks

@aclark4life aclark4life closed this Oct 3, 2016
@radarhere radarhere deleted the history branch October 3, 2016 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants